Allow for already-instantiated resampler to be passed to cpi() function#22
Open
mikoontz wants to merge 2 commits intobips-hb:masterfrom
Open
Allow for already-instantiated resampler to be passed to cpi() function#22mikoontz wants to merge 2 commits intobips-hb:masterfrom
cpi() function#22mikoontz wants to merge 2 commits intobips-hb:masterfrom
Conversation
…require additional parameters to be passed. This patch allows an already instantiated resampler to be passed to the cpi function instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cpi()function allows for custom resamplers to be passed to it. As written, the function automatically instantiates that resampler with no additional arguments, regardless of whether it has already been instantiated. However, calling$instantiatecan break with some resamplers since they might require additional parameters to be passed. This patch allows an already instantiated resampler to be passed to the cpi function instead. It uses theis_instantiatedfunctionality to check if the resampler has already been instantiated. In that case, it does not try to instantiate. In other cases, thecpi()function will try what it has done before-- to instantiate the resampler with no arguments.This arose when I was trying to use a "custom_cv" resampler (
rsmp("custom_cv")) which requires an additional argumentfto specify membership of each row in a factor level.