Bump netlayer to use tor binaries from verified tor-browser v9.5.4#4601
Closed
cd2357 wants to merge 1 commit intobisq-network:masterfrom
Closed
Bump netlayer to use tor binaries from verified tor-browser v9.5.4#4601cd2357 wants to merge 1 commit intobisq-network:masterfrom
cd2357 wants to merge 1 commit intobisq-network:masterfrom
Conversation
Upgrade netlayer to a version that uses tor binaries extracted from the latest tor-browser v9.5.4. The tor binaries in tor-browser v9.5.4 are the same version as from tor-browser 9.5.3 (namely tor v0.4.3.6). However, they were extracted from tor-browser binaries with matching SHA-256 hashes to the official browser binaries in https://dist.torproject.org/torbrowser/9.5.4/sha256sums-signed-build.txt
Contributor
Author
|
Closing this, since the alternative #4604 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a
netlayerversion that includes tor binaries extracted from the latest tor browser v9.5.4.For simplicity:
cdbe476from this branch)netlayerv0.6.8 + a change to use followingtor-binarynetlayerbumpstor-binarydependency to f3bc31f (based on commitf3bc31ffrom this branch)tor-binarydependency + change A + change Btor-browserv9.5.4 (instead of 9.5.3 used previously)SHA-256hashes of thetor-browserbinaries match the official ones (instead ofSHA-512hashes used previously, which are not published in the official tor repo anymore)tor-browserbinaries (used to extract the tor binaries) match the official checksumsNote: The tor binaries in
tor-browserv9.5.4 are the same version as from v9.5.3 (namely tor v0.4.3.6, as per the tor-browser changelog).So this PR doesn't bring or change any tor or netlayer functionality. It only ensures that the used tor binaries were extracted from verified
tor-browserpackages. The tor binaries are delivered as dependencies ofnetlayer.Fixes #4593