Skip to content

Update data stores for v1.9.23#7613

Merged
alejandrogarcia83 merged 1 commit intomasterfrom
update-data-stores-for-v1.9.23
Apr 13, 2026
Merged

Update data stores for v1.9.23#7613
alejandrogarcia83 merged 1 commit intomasterfrom
update-data-stores-for-v1.9.23

Conversation

@alejandrogarcia83
Copy link
Copy Markdown
Contributor

@alejandrogarcia83 alejandrogarcia83 commented Apr 10, 2026

full_1 full_2 full_3

Summary by CodeRabbit

  • Chores
    • Updated version tracking configuration for historical resource file versions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b3a30d04-d3a8-47ba-97da-c3a22c8b296b

📥 Commits

Reviewing files that changed from the base of the PR and between 9a76563 and 9df2d98.

📒 Files selected for processing (52)
  • common/src/main/java/bisq/common/app/Version.java
  • p2p/src/main/resources/AccountAgeWitnessStore_1.9.23_BTC_MAINNET
  • p2p/src/main/resources/BlindVoteStore_BTC_MAINNET
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_902001-903000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_903001-904000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_904001-905000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_905001-906000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_906001-907000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_907001-908000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_908001-909000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_909001-910000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_910001-911000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_911001-912000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_912001-913000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_913001-914000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_914001-915000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_915001-916000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_916001-917000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_917001-918000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_918001-919000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_919001-920000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_920001-921000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_921001-922000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_922001-923000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_923001-924000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_924001-925000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_925001-926000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_926001-927000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_927001-928000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_928001-929000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_929001-930000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_930001-931000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_931001-932000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_932001-933000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_933001-934000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_934001-935000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_935001-936000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_936001-937000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_937001-938000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_938001-939000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_939001-940000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_940001-941000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_941001-942000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_942001-943000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_943001-944000
  • p2p/src/main/resources/BsqBlocks_BTC_MAINNET/BsqBlocks_944001-945000
  • p2p/src/main/resources/BurningManAccountingStore_v3_BTC_MAINNET
  • p2p/src/main/resources/DaoStateStore_BTC_MAINNET
  • p2p/src/main/resources/ProposalStore_BTC_MAINNET
  • p2p/src/main/resources/SignedWitnessStore_BTC_MAINNET
  • p2p/src/main/resources/TempProposalStore_BTC_MAINNET
  • p2p/src/main/resources/TradeStatistics3Store_1.9.23_BTC_MAINNET

📝 Walkthrough

Walkthrough

A semantic version tag "1.9.23" was added to the HISTORICAL_RESOURCE_FILE_VERSION_TAGS constant in Version.java, extending the list of recognized historical resource file versions.

Changes

Cohort / File(s) Summary
Version History Update
common/src/main/java/bisq/common/app/Version.java
Added version tag "1.9.23" to the HISTORICAL_RESOURCE_FILE_VERSION_TAGS constant array.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version hops into the list today,
One-point-nine-point-twenty-three joins the way,
Historical tags in an ordered array,
A simple addition, hip-hip-hooray! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only image references without any textual description, required sections like 'Fixes #' issue reference, or explanation of the changes. Add a meaningful textual description explaining the purpose of updating the data store version, reference any related issues using 'Fixes #', and briefly describe what was changed and why.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update data stores for v1.9.23' is directly relevant to the changeset, which updates a version constant to support v1.9.23.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-data-stores-for-v1.9.23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 32c825a into master Apr 13, 2026
7 checks passed
@alejandrogarcia83 alejandrogarcia83 deleted the update-data-stores-for-v1.9.23 branch April 13, 2026 17:38
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.23 milestone Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants