Add testnet/regtest network detection to coinbase decoder#1578
Merged
0xf0xx0 merged 3 commits intobitaxeorg:masterfrom Apr 17, 2026
Merged
Add testnet/regtest network detection to coinbase decoder#15780xf0xx0 merged 3 commits intobitaxeorg:masterfrom
0xf0xx0 merged 3 commits intobitaxeorg:masterfrom
Conversation
7 tasks
warioishere
added a commit
to warioishere/ESP-Miner
that referenced
this pull request
Feb 25, 2026
Detect network from user address prefix (bc1/tb1/bcrt1/m/n/2) and use
the correct bech32 HRP and base58 version bytes when decoding coinbase
output addresses. Previously hardcoded to mainnet ("bc", 0x00/0x05).
- P2PKH: 0x6F for testnet (m/n prefix) instead of 0x00
- P2SH: 0xC4 for testnet (2 prefix) instead of 0x05
- Bech32: "tb" for testnet, "bcrt" for regtest instead of "bc"
- Add test cases for testnet P2PKH, P2SH, P2WPKH, P2TR and regtest P2WPKH
- Remove duplicate function declarations in coinbase_decoder.h
warioishere
force-pushed
the
feature/testnet-address-detection
branch
from
10f6f87 to
b4d256a
Compare
mutatrum
added a commit
to mutatrum/ESP-Miner
that referenced
this pull request
Mar 3, 2026
…1578) Author: wario_is_here <mario.hofmann@yourdevice.ch>
Collaborator
|
Can you resolve conflicts? |
Contributor
Author
done |
Collaborator
|
Can you remove the whitespace only changes? |
mutatrum
approved these changes
Apr 17, 2026
warioishere
force-pushed
the
feature/testnet-address-detection
branch
from
a8eca56 to
bc6d64f
Compare
Keep both testnet address tests and BIP-110 signaling tests.
warioishere
force-pushed
the
feature/testnet-address-detection
branch
from
bc6d64f to
c56998b
Compare
Collaborator
|
Build is failing due to another merge to master. If you update the branch once more, it should be green again. Thanks! |
Contributor
Author
|
done |
Collaborator
|
testing, will merge soon |
Collaborator
|
acked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bc1prefix instead oftb1/bcrt1Test plan
tb1prefixbcrt1prefixmorn2