fix: reset extranonce2 only if clean_jobs == true#1603
Open
blackmennewstyle wants to merge 7 commits intobitaxeorg:masterfrom
Open
fix: reset extranonce2 only if clean_jobs == true#1603blackmennewstyle wants to merge 7 commits intobitaxeorg:masterfrom
blackmennewstyle wants to merge 7 commits intobitaxeorg:masterfrom
Conversation
blackmennewstyle
changed the title
adammwest
reviewed
Mar 12, 2026
This PR improves the extranonce2 reset. It is only performed if clean_jobs == true. The previous code was triggering a cascade of duplicate shares after a varDiff change: - mining.set_difficulty - mining.notify with clean_jobs is set to false The behavior is described here: bitaxeorg#1587 (comment)
More explicit explanation for future code reviewers/contributors.
blackmennewstyle
force-pushed
the
master
branch
from
616dee4 to
7405ef1
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the extranonce2 reset.
It is only performed if clean_jobs == true.
The previous code was triggering a cascade of duplicate shares after a varDiff change:
cleanJobset to false #1587 (comment)