This repository was archived by the owner on Apr 11, 2024. It is now read-only.
signature tests failing#99
Open
paOol wants to merge 3 commits intobitcoin-computer:masterfrom
paOol:cryptoES6
Open
signature tests failing#99paOol wants to merge 3 commits intobitcoin-computer:masterfrom paOol:cryptoES6
paOol wants to merge 3 commits intobitcoin-computer:masterfrom
paOol:cryptoES6
Conversation
tests passing.
a lot of files use this one, so the tests errors are much more extensive. I didn't commit the changes to test/crypto/signature because it's probably easier to start from the beginning instead of picking up where I left off. I definitely need another pair of eyes because I have probably looked over it so many times and am missing something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need an extra pair of eyes on this one since the tests are much more extensive than other files.