Open
Conversation
fanquake
reviewed
Mar 22, 2025
laanwj
reviewed
Mar 27, 2025
laanwj
reviewed
Mar 27, 2025
Member
|
Why are you changing the permissions of clang-format.py? |
This comment was marked as off-topic.
This comment was marked as off-topic.
list-pulls.py: Remove unused import. termlib/attr.py: Explicit class methods. termlib/tableprinter.py: Adapts signature change. treehash512.py: Remove unused imports.
maflcko
reviewed
Sep 2, 2025
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright (c) 2017 The Bitcoin Core developers | |||
| # Copyright (c) 2017, 2025 The Bitcoin Core developers | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2017, 2025 The Bitcoin Core developers | |
| # Copyright (c) 2017-present The Bitcoin Core developers |
nit: If this is touched, might as well remove the years, or just append -present, to avoid having to re-touch this again in the future for style fixups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignore: Ignore PyCharm metadata.
clang-format.py: Python 3.
list-pulls.py: Remove unused import.
termlib/attr.py: Explicit class methods.
termlib/tableprinter.py: Adapts signature change.
treehash512.py: Remove unused imports.