Skip to content

update-translations: Preserve XML declaration and DOCTYPE#196

Open
hebasto wants to merge 1 commit intobitcoin-core:mainfrom
hebasto:260311-doctype
Open

update-translations: Preserve XML declaration and DOCTYPE#196
hebasto wants to merge 1 commit intobitcoin-core:mainfrom
hebasto:260311-doctype

Conversation

@hebasto
Copy link
Copy Markdown
Member

@hebasto hebasto commented Mar 11, 2026

postprocess_translations currently strips the XML declaration and DOCTYPE from the original files.

For example, in Bitcoin Core on the master branch, you can see bitcoin_en.ts has the headers while bitcoin_fr.ts does not:

$ head -n 4 src/qt/locale/bitcoin_en.ts 
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="en">
<context>
$ head -n 2 src/qt/locale/bitcoin_fr.ts 
<TS version="2.1" language="fr">
<context>

This PR ensures they are manually re-added to prevent any possible Qt compatibility issues.

`postprocess_translations` currently strips the XML declaration and
DOCTYPE from the original files. This commit ensures they are manually
re-added to prevent any possible Qt compatibility issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant