update-translations: Preserve XML declaration and DOCTYPE#196
Open
hebasto wants to merge 1 commit intobitcoin-core:mainfrom
Open
update-translations: Preserve XML declaration and DOCTYPE#196hebasto wants to merge 1 commit intobitcoin-core:mainfrom
hebasto wants to merge 1 commit intobitcoin-core:mainfrom
Conversation
`postprocess_translations` currently strips the XML declaration and DOCTYPE from the original files. This commit ensures they are manually re-added to prevent any possible Qt compatibility issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postprocess_translationscurrently strips the XML declaration and DOCTYPE from the original files.For example, in Bitcoin Core on the master branch, you can see
bitcoin_en.tshas the headers whilebitcoin_fr.tsdoes not:This PR ensures they are manually re-added to prevent any possible Qt compatibility issues.