ci: enable clang-tidy in macOS job, use nullptr#262
Open
Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Open
ci: enable clang-tidy in macOS job, use nullptr#262Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Sjors wants to merge 2 commits intobitcoin-core:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
|
concept ACK, will test locally later today. TIL |
Member
To be pedantic, the variable name is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit reproduces #261:
https://github.com/bitcoin-core/libmultiprocess/actions/runs/23348264051/job/67919536711?pr=262
Using
clang-tidyin the macOS job increases the runtime from ~1 minute to 2.5 minutes, which shouldn't be a problem.The second commit fixes it.