A couple improvements to BIP 54 test vectors#110
Open
darosior wants to merge 4 commits intobitcoin-inquisition:29.xfrom
Open
A couple improvements to BIP 54 test vectors#110darosior wants to merge 4 commits intobitcoin-inquisition:29.xfrom
darosior wants to merge 4 commits intobitcoin-inquisition:29.xfrom
Conversation
It was requested by ariard during review.
hodlinator
approved these changes
Mar 16, 2026
hodlinator
left a comment
hodlinator
left a comment
There was a problem hiding this comment.
ACK 27957d2
I support including a transaction spending Taproot-inputs that (after stripping the witness data) ends up at the invalid 64 bytes.
ariard
reviewed
Mar 19, 2026
| RecordTestCase(test_vectors, CTransaction{tx_copy}, /*valid=*/false, "A 64-byte Segwit transaction (1 p2tr input, 1 p2a output)."); | ||
| } | ||
|
|
||
| // A semi-realistic 64-byte transaction: 1 Taproot input with an annex, 1 OP_RETURN output. |
There was a problem hiding this comment.
maybe a test case for a segwit v2+ to verify the validity is not changed by the novel BIP54 checks.
ofc, no reason why it would change anything for v2 - v16.
don’t remember if there is already another test case for it elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on some review feedback from #99 and from bitcoin/bips#2015, this: