bip-0054: update forward compat section with Bitcoin Core v30#2044
bip-0054: update forward compat section with Bitcoin Core v30#2044murchandamus merged 1 commit intobitcoin:masterfrom
Conversation
| that makes this type of transaction non-standard should be widely adopted before this soft fork is | ||
| considered for activation. | ||
| Bitcoin Core version [30.0][Core 30.0] and later will not generate a block template including a | ||
| transaction that violates the signature operations limit introduced in this BIP. |
There was a problem hiding this comment.
| transaction that violates the signature operations limit introduced in this BIP. | |
| transaction that violates the signature operations limit introduced in this BIP (see https://github.com/bitcoin/bitcoin/pull/32521). |
Do you think it would be useful to link to bitcoin/bitcoin#32521 here?
There was a problem hiding this comment.
Yeah i thought about it but figured it was superfluous to link to implementation details.
There was a problem hiding this comment.
What is a rough threshold for "widely adopted" and, depending on what it is relative to current v30 adoption, should a mention about adoption remain for now?
There was a problem hiding this comment.
I am not sure what's a good threshold to give. Ideally all of them would be upgraded before activation, but you also do not want to give a too small minority of miners a veto power over consensus changes.
If something is to be kept it should apply to the whole section really, although the two most concerning items are the coinbase restriction and this one. I'm not sure. On the other hand having a whole section about miner forward compatibility sort of speaks for itself.
The BIP 54 sigops limit was made a standardness rules in Bitcoin Core 30.0.
darosior
force-pushed
the
2511_bip54_forward_compat
branch
from
8c526c0 to
1076d90
Compare
|
Rebased after #2015 was merged (thanks!). |
3 participants
The BIP 54 sigops limit was made a standardness rule in Bitcoin Core 30.0 with the merge of bitcoin/bitcoin#32521.