Skip to content

rename bip322 feature to message_signer#301

Merged
tvpeter merged 3 commits into
bitcoindevkit:masterfrom
aagbotemi:chore/bump-bdk-message-signer
Jul 20, 2026
Merged

rename bip322 feature to message_signer#301
tvpeter merged 3 commits into
bitcoindevkit:masterfrom
aagbotemi:chore/bump-bdk-message-signer

Conversation

@aagbotemi

@aagbotemi aagbotemi commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

This PR renames the bip322 to message_signer.

Changelog notice

  • Rename bip322 feature to message_signer

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.45%. Comparing base (7c2dfac) to head (b0e6a3c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   57.45%   57.45%           
=======================================
  Files          22       22           
  Lines        3695     3695           
=======================================
  Hits         2123     2123           
  Misses       1572     1572           
Flag Coverage Δ
rust 57.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvpeter tvpeter added the chore Non-coding related work label Jul 14, 2026
@tvpeter tvpeter added this to the CLI 4.0.0 milestone Jul 14, 2026
    - bump bdk_wallet to 3.1.0
    - replace Network with NetworkKind
    - replace TxBuilder::include_output_redeem_witness_script with TxBuilder::add_global_xpubs
@aagbotemi
aagbotemi force-pushed the chore/bump-bdk-message-signer branch from 652c30d to 187a5da Compare July 18, 2026 23:09

@tvpeter tvpeter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aagbotemi,

I left a comment.

Thank you.

Comment thread CHANGELOG.md Outdated
@aagbotemi
aagbotemi force-pushed the chore/bump-bdk-message-signer branch from 187a5da to b0e6a3c Compare July 19, 2026 21:03

@tvpeter tvpeter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b0e6a3c

@tvpeter tvpeter changed the title bump bdk message signer rename bip322 feature to message_signer Jul 20, 2026
@tvpeter
tvpeter merged commit 0d81bd8 into bitcoindevkit:master Jul 20, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this to Done in BDK-CLI Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants