fix(chain): skip evicted txs in leftover canonicalization#2240
Open
noahjoeris wants to merge 2 commits into
Open
fix(chain): skip evicted txs in leftover canonicalization#2240noahjoeris wants to merge 2 commits into
noahjoeris wants to merge 2 commits into
Conversation
Seen already filters last_evicted >= last_seen; leftover did not, so unmatched-anchor txs could reappear as unconfirmed after drop/RBF.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
+ Coverage 78.65% 78.68% +0.02%
==========================================
Files 30 30
Lines 5909 5922 +13
Branches 279 281 +2
==========================================
+ Hits 4648 4660 +12
- Misses 1185 1186 +1
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
evanlinjin
requested changes
Jul 21, 2026
evanlinjin
left a comment
evanlinjin
left a comment
Member
There was a problem hiding this comment.
Thanks for finding and fixing this. These changes are logically correct. I have some suggestions with two possible directions.
Comment on lines
+265
to
+275
| fn is_evicted_leftover(&self, txid: Txid) -> bool { | ||
| let node = self | ||
| .tx_graph | ||
| .get_tx_node(txid) | ||
| .expect("leftover transaction must exist"); | ||
| match (node.last_seen, node.last_evicted) { | ||
| (_, None) => false, | ||
| (Some(seen), Some(evicted)) => evicted >= seen, | ||
| (None, Some(_)) => true, | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Two things:
- The
_leftoversuffix is wrong here - the method's logic has no understanding of what is leftover or not. - The
last_evicted >= last_seencheck is also used byTxGraph::txids_by_descending_anchor_heightbut the logic there did not consider thelast_seen = None, last_evicted = Somecase (which is wrong).
Possible directions:
- Introduce
TxNode::is_evicted -> boolmethod which would be a pure mempool-observation predicate (does not take anchoring into account - docs need to be clear about this). Thus, getting rid ofis_evicted_leftover. - Rename
is_evicted_leftoverto justis_evictedand create a ticket to introduceTxNode::is_evicted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CanonicalStage::LeftOverTxsdoesn't filter evicted txs and can mark them canonical. So a stale-anchored tx that was evicted/replaced could still show as unconfirmed.Example: a tx confirms, then a reorg leaves only a stale anchor. Leftover treats it as unconfirmed. If it's later RBF'd or missing from the mempool, leftover still marks it unconfirmed.
Changelog notice
last_evicted >= last_seen.Checklists
All Submissions:
Bugfixes: