π‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability in external binary execution#10
Conversation
β¦ name - Validates `profile.bitcoin_cli` to ensure the executable file name is strictly `bitcoin-cli` or `bitcoin-cli.exe`. - Removes unused and duplicate `run_bitcoin_cli` from `src/wallet_service.rs` to centralize command execution and minimize attack surface. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection / arbitrary code execution via configuration profile manipulation. If an attacker gains write access to
profile.json, they could changebitcoin_clito another system executable (e.g.,rm,curl,bash), allowing them to execute arbitrary code.π― Impact: High. An attacker could completely compromise the host system using "Living off the Land" techniques.
π§ Fix:
src/utils.rsrun_bitcoin_clito strictly enforce that the executing binary's file name isbitcoin-cliorbitcoin-cli.exe. This allows absolute paths (e.g./usr/local/bin/bitcoin-cli) while ensuring safety.run_bitcoin_clifromsrc/wallet_service.rsto enforce centralization and prevent developers from accidentally using an unvalidated execution path.β Verification: Ensure the test suite passes,
cargo checkandcargo clippysucceeds, and that using an invalid binary name via the configuration profile throws an error.PR created automatically by Jules for task 18227969967410617778 started by @bitcoiner-dev