Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability in external binary execution#10

Open
bitcoiner-dev wants to merge 1 commit intomasterfrom
sentinel-fix-bitcoin-cli-execution-18227969967410617778
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability in external binary execution#10
bitcoiner-dev wants to merge 1 commit intomasterfrom
sentinel-fix-bitcoin-cli-execution-18227969967410617778

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection / arbitrary code execution via configuration profile manipulation. If an attacker gains write access to profile.json, they could change bitcoin_cli to another system executable (e.g., rm, curl, bash), allowing them to execute arbitrary code.
🎯 Impact: High. An attacker could completely compromise the host system using "Living off the Land" techniques.
πŸ”§ Fix:

  1. Added validation in src/utils.rs run_bitcoin_cli to strictly enforce that the executing binary's file name is bitcoin-cli or bitcoin-cli.exe. This allows absolute paths (e.g. /usr/local/bin/bitcoin-cli) while ensuring safety.
  2. Removed an unused duplicate of run_bitcoin_cli from src/wallet_service.rs to enforce centralization and prevent developers from accidentally using an unvalidated execution path.
    βœ… Verification: Ensure the test suite passes, cargo check and cargo clippy succeeds, and that using an invalid binary name via the configuration profile throws an error.

PR created automatically by Jules for task 18227969967410617778 started by @bitcoiner-dev

… name

- Validates `profile.bitcoin_cli` to ensure the executable file name is strictly `bitcoin-cli` or `bitcoin-cli.exe`.
- Removes unused and duplicate `run_bitcoin_cli` from `src/wallet_service.rs` to centralize command execution and minimize attack surface.

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant