fix: 🐛 Conditional into ternary & further github actions refinement#778
Open
fix: 🐛 Conditional into ternary & further github actions refinement#778
Conversation
Initial commit with Github Actions currently with cz check and yarn audit
PR and CODEQL yml added
Changed logical conditional renders into ternary renditions and adjusted pull-request.yml to ignore deendabot
mlobac
reviewed
Sep 27, 2021
| return ( | ||
| <> | ||
| {!__DEV__ && <WithCodePush />} | ||
| {!__DEV__ ? <WithCodePush /> : null} |
There was a problem hiding this comment.
In this case I propose not to use negation
{__DEV__ ? null : <WithCodePush /> }
| <View style={styles.container}> | ||
| <Animated.Text style={[styles.label, { top, fontSize }]}>{label}</Animated.Text> | ||
| {!!suffix && <Text style={styles.suffix}>{suffix}</Text>} | ||
| {!!suffix ? <Text style={styles.suffix}>{suffix}</Text> : null} |
| <Image testID={testID} source={source} style={[styles.image, imageStyle]} resizeMode="contain" /> | ||
| <Text style={styles.description}>{description}</Text> | ||
| {buttonProps && <Button testID="message-close-button" {...buttonProps} />} | ||
| {buttonProps ? <Button testID="message-close-button" {...buttonProps} /> : null} |
There was a problem hiding this comment.
Not for this PR but maybe for later we should not use spread on components props?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(A few words about the PR)
Where should the reviewer start?
Any background context you want to provide?
Any scout cleaning/refactoring?
Any blog post related to the solution you have used?
Todos:
Required reviewers: