Adding default prometheusRule in helmChart to watch out of sync secrets#1980
Open
William-LP wants to merge 2 commits into
Open
Adding default prometheusRule in helmChart to watch out of sync secrets#1980William-LP wants to merge 2 commits into
William-LP wants to merge 2 commits into
Conversation
Signed-off-by: William-LP <10053686+William-LP@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This change adds support for deploying a PrometheusRule resource for the Sealed Secrets Helm chart.
It allows users to define alerting rules for Sealed Secrets via
values.yamlundermetrics.prometheusRule.Benefits
ServiceMonitorpattern in the chartPossible drawbacks
Applicable issues
Additional information
PrometheusRule is optional and disabled by default (
enabled: false) to avoid unintended alerts in new deployments.