Merged
Conversation
PhillypHenning
left a comment
There was a problem hiding this comment.
aws_ecs_efs
The EFS configuration that was added, based on the variable name, seems to be for ECS usage only. I just want to confirm:
- Do we support EFS mounting to an EC2 ?
- Is the implementation different between EC2 and ECS?
Contributor
Author
Implementation of both is completely different. ECS configures it at the task and container definition level, EC2 needs to create a file with the disk info that's going to be mounted later on by an Ansible task. What could be added
|
PhillypHenning
approved these changes
Jan 23, 2026
|
|
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding EFS volume handling to ECS
Fixing some dependencies of lb_targets in ECS
Cosmetic README fixes