Fix startup error spam: empty point list during initialization#36
Open
Fix startup error spam: empty point list during initialization#36
Conversation
On Node-RED startup, buildJsonTree() could fire before the cache file finished loading, causing repeated "Unable to build network tree, empty point list" errors in the console. Two changes: 1. buildJsonObject() now returns early instead of throwing when a device has no points yet — this is a normal transient state, not an error. 2. Added a cacheLoaded guard so scheduled queryDevices/buildJsonTree tasks wait until readCachedFile() completes before running. Fixes #34
ravz
force-pushed
the
fix/startup-empty-pointlist-error
branch
from
3f8ebf1 to
68b09f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildJsonObject()now returns early instead of throwing when a device has no points yet — this is a normal transient state on startup, not an errorcacheLoadedguard so scheduledqueryDevices/buildJsonTreetasks wait untilreadCachedFile()completes before runningreinitializeClient()which has the same scheduled task patternFixes #34
Test plan