Skip to content

Support expanded support for converting to boolean values.#3

Open
jloveridge wants to merge 3 commits intobitrinjani:masterfrom
gradecam:feature/expanded-boolean
Open

Support expanded support for converting to boolean values.#3
jloveridge wants to merge 3 commits intobitrinjani:masterfrom
gradecam:feature/expanded-boolean

Conversation

@jloveridge
Copy link

Be a bit more permissive on what values will result in a true from the boolean conversion. Additionally this fixes an issue where an exception is thrown if the value being converted happens to be null.

// examples where this could have caused an exception
const booleanConversionThrows = {
  propIsNull: JSON.stringify({value: null}),
  propIsNaN: JSON.stringify({value: NaN}),
};

@coveralls
Copy link

coveralls commented Apr 12, 2018

Coverage Status

Coverage decreased (-5.8%) to 94.231% when pulling e0cc45d on gradecam:feature/expanded-boolean into 109f38a on bitrinjani:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants