Add $withDeleted parameter to partner lookup - #569
Open
mesilov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bool $withDeleted = falsetoBitrix24PartnerRepositoryInterface::findByBitrix24PartnerNumber().Default partner-number lookup continues to hide soft-deleted partners. Callers that need to handle import/upsert collisions can pass
withDeleted: trueto detect an existing soft-deleted partner before attempting an insert.Contract tests cover both default filtering and explicit inclusion of deleted partners in the in-memory reference implementation.
Closes #490
Test plan
make lint-cs-fixer— passedmake lint-rector— passedmake lint-phpstan— passedmake lint-deptrac— passedmake test-unit— passedGenerated with Codex