Skip to content

Add $withDeleted parameter to partner lookup - #569

Open
mesilov wants to merge 1 commit into
v3-devfrom
feature/490-with-deleted-partner-lookup
Open

Add $withDeleted parameter to partner lookup#569
mesilov wants to merge 1 commit into
v3-devfrom
feature/490-with-deleted-partner-lookup

Conversation

@mesilov

@mesilov mesilov commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator
Q A
Bug fix? yes
New feature? yes
Deprecations? no
Issues Fix #490
License MIT

Adds bool $withDeleted = false to Bitrix24PartnerRepositoryInterface::findByBitrix24PartnerNumber().

Default partner-number lookup continues to hide soft-deleted partners. Callers that need to handle import/upsert collisions can pass withDeleted: true to detect an existing soft-deleted partner before attempting an insert.

$partner = $repository->findByBitrix24PartnerNumber($number, withDeleted: true);

Contract tests cover both default filtering and explicit inclusion of deleted partners in the in-memory reference implementation.

Closes #490

Test plan

  • make lint-cs-fixer — passed
  • make lint-rector — passed
  • make lint-phpstan — passed
  • make lint-deptrac — passed
  • make test-unit — passed
  • Integration phase — not applicable; this is a contract-only change with no REST service scope

Generated with Codex

@mesilov mesilov added this to the 3.5.0 milestone Aug 5, 2026
@mesilov mesilov self-assigned this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant