Add new skill for breakdown#130
Conversation
Plugin Validation Summary — PR #130Plugin: Three validation passes were run: plugin structure (plugin-validator), skill quality (skill-reviewer), and security/config review (reviewing-claude-config). Overall Assessment: REQUEST CHANGESThe new skill file itself is structurally clean, well-written, and free of security issues. However, the PR is missing the mandatory version bump and changelog entry required by Critical Issues (must fix)1. Plugin version not bumped
2. Marketplace version stale
3. Missing CHANGELOG entry
Major Issues (should fix)4. SKILL.md over the recommended word-count target
5. No
|
| Check | Tool | Result |
|---|---|---|
| Plugin manifest structure | plugin-validator | FAIL — missing version bump + changelog |
| Marketplace consistency | plugin-validator | FAIL — marketplace.json version stale |
| Skill YAML frontmatter | skill-reviewer + plugin-validator | PASS |
| Skill content quality | skill-reviewer | Warnings — word count, no examples, description shape |
| Progressive disclosure | skill-reviewer | Warning — single file, no references/ or examples/ |
| File references | skill-reviewer | PASS — no broken local references |
| Secrets / credentials | reviewing-claude-config | PASS |
| Tool permission scoping | reviewing-claude-config | PASS |
| Prompt-injection surface | reviewing-claude-config | PASS |
| File size limits | reviewing-claude-config | PASS (239 / 500 lines) |
Recommended Action
- Run the version bump:
echo "y" | ./scripts/bump-plugin-version.sh bitwarden-delivery-tools 1.4.0 - Add a CHANGELOG
[1.4.0]entry describing the new skill. - Re-run local validators:
./scripts/validate-plugin-structure.sh bitwarden-delivery-toolsand./scripts/validate-marketplace.sh bitwarden-delivery-tools. - (Recommended, not blocking) — apply progressive disclosure by extracting reference-shaped sections to
references/and adding anexamples/directory; tighten the description.
withinfocus
left a comment
There was a problem hiding this comment.
There are a number of validation improvements called out as comments, but generally-speaking and beyond those fixes I would suggest this land differently -- right now it's one isolated skill with no wireup. This should be a replacement for the skill in https://github.com/bitwarden/ai-plugins/blob/main/plugins/bitwarden-delivery-tools/skills/writing-tech-breakdowns/SKILL.md and to a lesser extent https://github.com/bitwarden/ai-plugins/blob/main/plugins/bitwarden-delivery-tools/skills/coordinating-cross-team-breakdown/SKILL.md. In addition, a search of "breakdown" across this repo to confirm touchpoints will be important.
📔 Objective
Adds a new skill for breakdown that understands the context of the phased breakdown and construction approach in https://github.com/bitwarden/tech-breakdowns/pull/3.