feat(code-review): route Claude config changes to claude-config-validator#147
Draft
withinfocus wants to merge 1 commit into
Draft
Conversation
…ator When a diff touches Claude configuration files (CLAUDE.md, AGENT.md, SKILL.md, hooks, slash commands, .claude/ settings, MCP config), both review paths now invoke the claude-config-validator skill: - Single-agent reviewer (bitwarden-code-reviewer): detects config files in Step 1 and invokes Skill(reviewing-claude-config) during Cross-Plugin Enrichment, folding findings into classification/validation. - performing-multi-agent-code-review: conditional Step 3 "Agent 4" (source_agent: "config") whose findings flow through validation, severity audit, and the report. Extended the source_agent enum and report label table accordingly. The dependency on claude-config-validator is optional in both paths; if it is not installed the review falls back to existing knowledge. Bumps bitwarden-code-review to 1.13.0 (past PR #146's 1.12.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.slack.com/archives/C0B44P2J5FB/p1781810216367409
📔 Objective
Neither the
bitwarden-code-revieweragent nor theperforming-multi-agent-code-reviewskill had any specific handling for reviewing Claude configuration itself. This PR routes Claude-related changes through theclaude-config-validatorplugin in both review paths.When a diff touches Claude configuration files (
CLAUDE.md, agentAGENT.md, skillSKILL.md, hook definitions, slash commands,.claude/settings, or MCP config):bitwarden-code-reviewer): detects config files in Step 1 and invokesSkill(reviewing-claude-config)during Cross-Plugin Enrichment, folding its findings into classification/validation.performing-multi-agent-code-review: launches a conditional Step 3 "Agent 4" (source_agent: "config") whose findings flow through validation, severity audit, and the report. Thesource_agentenum (finding-shape.md) and report label table (report-template.md) were extended accordingly.The dependency on
claude-config-validatoris optional in both paths — consistent with the existing Cross-Plugin Enrichment convention. If the plugin isn't installed, the review falls back to existing review knowledge.Bumps
bitwarden-code-reviewto 1.13.0 (intentionally past PR #146's 1.12.0, since this is stacked on that branch).