Skip to content

Skill for completing tech breakdowns#148

Draft
trmartin4 wants to merge 2 commits into
tech-breakdown-tasks-skillfrom
tech-breakdown-complete-skill
Draft

Skill for completing tech breakdowns#148
trmartin4 wants to merge 2 commits into
tech-breakdown-tasks-skillfrom
tech-breakdown-complete-skill

Conversation

@trmartin4

@trmartin4 trmartin4 commented Jun 19, 2026

Copy link
Copy Markdown
Member

📔 Objective

Adds the next in a sequence of changes to decompose and enhance the existing writing-tech-breakdowns skill, for use with our new tech-breakdowns repo.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Plugin Validation Summary — PR #148

Plugin: bitwarden-delivery-tools (v2.1.0)
Change: Adds the completing-breakdown skill + version bump to 2.1.0.

Result: ✅ All checks pass. No critical or major issues. Two minor, non-blocking notes below.


1. Plugin structure (plugin-validator)

Check Status
plugin.json valid JSON, required fields, kebab-case name
Semantic version 2.1.0 valid
Version consistent across plugin.json:3, marketplace.json:81, CHANGELOG.md:8
marketplace.json description matches plugin.json description
Skill auto-discovery location (skills/completing-breakdown/SKILL.md); dir name matches frontmatter name
CHANGELOG follows Keep a Changelog (dated entry ## [2.1.0] - 2026-06-19, ### Added, descending order)
README documents the new skill (README.md:34)
No hardcoded credentials

2. Skill review (skill-reviewer) — skills/completing-breakdown/SKILL.md

  • Frontmatter — valid; name + description present, name matches directory. Uses argument-hint, arguments, allowed-tools — an exact structural match to sibling skills (decomposing-into-tasks, starting-breakdown, developing-breakdown-plan). Conforms to the plugin's established convention.
  • Description — third-person, ~510 chars, with concrete trigger phrases and a clear "Use when" clause. Strong.
  • Writing style — consistently imperative/infinitive throughout.
  • Word count — ~510 body words. Below the 1,000–3,000 target, but appropriate for a narrow, procedural archival task; siblings in this plugin range 142–3,138 words, so a lean file conforms to the plugin norm. Not a defect.
  • Progressive disclosure — single self-contained SKILL.md with no references//examples/ pointers; none are warranted at this scope, and no broken references exist.
  • Strengths — HARD-GATE encodes real destructive-op preconditions (already-archived check, clean working tree); Key Principles give concrete ordering-safety reasoning (status-flip-then-move, git mv to preserve history); leaves the commit to the user like the plugin's other git-touching skills.

3. Security validation (reviewing-claude-config)

Check Status
No settings.local.json committed ✅ (none present)
No committed secrets / hardcoded credentials in any changed file
allowed-tools permission scoping ✅ Narrowly scoped — Read, Edit, Glob, AskUserQuestion plus Bash(git mv:*), Bash(git status:*), Bash(mkdir:*). No blanket Bash.
Dangerous command auto-approvals ✅ None — Bash patterns are minimal, reversible, and task-specific (no rm, network, or pipe commands).

plugin.json, CHANGELOG.md, and README.md contain only public URLs and documentation — no sensitive material.


Minor notes (non-blocking, optional)

  • SKILL.md:5arguments: breakdown is not part of the documented Claude Code skills frontmatter schema (which defines argument-hint, correctly present on line 4). It is, however, an intentional repo convention used identically across all sibling breakdown skills, and unknown keys are ignored. No change needed unless the team decides to drop it plugin-wide.
  • SKILL.md:36, 61–62 — bare angle-bracket path templates (<team>/<JIRA-KEY>-<short-slug>/) are not wrapped in backticks here, unlike line 13. Cosmetic only; SKILL.md is consumed by the model, not rendered as HTML, and the same form is used by sibling skills. Optional consistency tidy-up.

False positive excluded

The skill-reviewer initially flagged an orphan </output> tag at "line 74." Verified against the file: it is 73 lines with no such tag — the </output> was the Read tool's output wrapper, not file content. No action needed; this is not a real issue.


Recommendation: APPROVE. Version bump, changelog, README, structure, and security are all correct. The only findings are cosmetic and conform to existing plugin conventions.

@trmartin4 trmartin4 changed the title Completion skill. Skill for completing tech breakdowns Jun 19, 2026
@trmartin4 trmartin4 mentioned this pull request Jun 19, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant