Skip to content

PM-39072: Feat: Update premium action card copy#7071

Merged
david-livefront merged 1 commit into
mainfrom
PM-39072-premium-dialog-copy
Jun 17, 2026
Merged

PM-39072: Feat: Update premium action card copy#7071
david-livefront merged 1 commit into
mainfrom
PM-39072-premium-dialog-copy

Conversation

@david-livefront

@david-livefront david-livefront commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-39072

📔 Objective

This PR updates the premium action card on the VaultScreen to use new copy.

📸 Screenshots

Before After

@david-livefront david-livefront requested a review from a team as a code owner June 17, 2026 16:10
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 17, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development labels Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Code Review: PM-39072 — Update premium dialog copy

Reviewed the change updating the UpgradePremium action card button on the Vault screen from "Upgrade to Premium" to "Learn more", plus the two corresponding test assertions.

Summary

Looks good. This is a clean, well-scoped copy change.

  • The learn_more string resource exists in the :ui module (strings.xml:214).
  • Both affected VaultScreenTest assertions were updated to match the new copy, keeping the click-behavior test intact.
  • The change is correctly limited to the UpgradePremium action card. The upgrade_to_premium string remains in use across other premium-gating dialogs (Send, Attachments, Vault Item, etc.), which is expected and outside this ticket's scope.
  • Existing behavior is preserved: onActionClick still routes through actionCardClickNavigateToUpgradePremiumonNavigateToPlan(), so only the label changed.

Notes

  • The sibling UpgradedToPremium card already uses the same learn_more label but with isExternalLink = true. The two cards are mutually exclusive states, so no UX ambiguity is introduced; the differing isExternalLink is consistent with each card's distinct navigation target (internal plan screen vs. external link).

No blocking issues, no suggestions. 👍

@david-livefront david-livefront changed the title PM-39072: Feat: Update premium dialog copy PM-39072: Feat: Update premium action card copy Jun 17, 2026
@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @LRNcardozoWDF

@david-livefront david-livefront added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 8431211 Jun 17, 2026
28 of 33 checks passed
@david-livefront david-livefront deleted the PM-39072-premium-dialog-copy branch June 17, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants