PM-37319: Feat: Update premium dialog titles

[david-livefront]

🎟️ Tracking

PM-37319

📔 Objective

📸 Screenshots

Before	After

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the consolidation of premium-feature dialog titles to a single reusable premium_subscription_required string across 6 screens, plus the related refactor of the Send dialog states. The SendViewModel change (always showing FileTypeRequiresPremium instead of the isInAppUpgradeAvailable()-gated Error fallback) and the AddEditSendViewModel change (collapsing EmailAuthRequiresPremium and a defensive Error into a parameterized PremiumRequired(message) state) were traced and verified — both render correctly and remain consistent with the existing plan-modal navigation. Test updates match the code changes and the removed source strings have no remaining Kotlin references.

Code Review Details

No findings.

Notes (not blocking, not posted inline):

• Three test names in AddEditSendScreenTest.kt still reference the removed EmailAuthRequiresPremium state; the bodies were correctly updated to PremiumRequired. Cosmetic only.

[david-livefront]

Thanks @SaintPatrck