[PM-38966] feat: Add fill assist opt-in setting and privacy gate#7075
Draft
aj-rosado wants to merge 1 commit into
Draft
[PM-38966] feat: Add fill assist opt-in setting and privacy gate#7075aj-rosado wants to merge 1 commit into
aj-rosado wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38966
📔 Objective
Settings UI
FillAssistTargetingRulesfeature flag is enabledhttps://bitwarden.com/help/fill-assist/Privacy gate
FillAssistManagerImpl.syncIfNecessary()now exits early when the user has not opted in — no background CDN requests while the feature is disabledsyncIfNecessary()call so rules are available without waiting for the next server-config emissionAutofill integration
AutofillParserImplapplies fill-assist rules only when both the feature flag andisFillAssistEnabledare trueData layer
isFillAssistEnabledper-user preference inSettingsDiskSource/SettingsRepository(keyed withappendIdentifier(userId), stored unencrypted)FillAssistService, manifest + forms JSON parsing, 6-hour re-fetch throttle with CID-based deduplicationCSS selector matching
tag#id,[attr='value'], CSS descendant selectors, and Shadow DOM (>>>) notation[placeholder='Email address']) are preservedHtmlInfo.matchesSelectorClause()extracted toHtmlInfoExtensionsfollowing the existingandroid.util.Pairisolation patternTests
FillAssistManagerTest: new case — sync does nothing whenisFillAssistEnabled = falseAutoFillViewModelTest: toggle-on persists setting and callssyncIfNecessary(); toggle-off persists setting and skips sync; info-click emitsNavigateToFillAssistHelpAutoFillScreenTest: switch hidden when flag off, switch visible when flag on, toggle sendsFillAssistToggleClick,NavigateToFillAssistHelpcallsintentManager.launchUriFillAssistViewNodeExtensionsTest: all previously commented-out tests now pass viamockkStatic(HtmlInfo::matchesSelectorClause)📸 Screenshots