Skip to content

[PM-33374] Fix getAllDecrypted when using the SDK#19503

Merged
nikwithak merged 4 commits intomainfrom
vault/pm-33374-fix-sdk-list
Mar 13, 2026
Merged

[PM-33374] Fix getAllDecrypted when using the SDK#19503
nikwithak merged 4 commits intomainfrom
vault/pm-33374-fix-sdk-list

Conversation

@nikwithak
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33374

📔 Objective

Consumes the new get_all() fucntion from the SDK, which returns CipherView[] instead of CipherListView[], fixing conversion issues.

@nikwithak nikwithak requested a review from a team as a code owner March 11, 2026 19:36
@nikwithak nikwithak requested a review from Jingo88 March 11, 2026 19:36
gbubemismith
gbubemismith previously approved these changes Mar 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026

Logo
Checkmarx One – Scan Summary & Details04e13145-f49d-49bc-9e1f-7831de90d3cf

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link
Copy Markdown

@nikwithak nikwithak requested a review from gbubemismith March 13, 2026 21:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.43%. Comparing base (55d0595) to head (6a4b712).
⚠️ Report is 177 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19503   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files        3768     3768           
  Lines      110946   110946           
  Branches    16896    16896           
=======================================
  Hits        50411    50411           
  Misses      58315    58315           
  Partials     2220     2220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nikwithak nikwithak merged commit 34fad75 into main Mar 13, 2026
142 checks passed
@nikwithak nikwithak deleted the vault/pm-33374-fix-sdk-list branch March 13, 2026 21:59
@djsmith85 djsmith85 added browser Browser Extension cli CLI Application desktop Desktop Application web labels Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser Browser Extension cli CLI Application desktop Desktop Application web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants