[BRE-1522] Update publish mobile GitHub release with test workflow#644
Open
gitclonebrian wants to merge 9 commits into
Open
[BRE-1522] Update publish mobile GitHub release with test workflow#644gitclonebrian wants to merge 9 commits into
gitclonebrian wants to merge 9 commits into
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
…p cred download if no cred file name provided
…on platform agnostic
…rets to be passed in. in order to do that, the reuable workflow needs them to be explicitly defined there too
5be8f27 to
42b8a28
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
BRE-1522
📔 Objective
Adds a regression test workflow for
_publish-mobile-github-release.ymlthat runs automatically on PRs that change it, along with documentation.Files Added
test-publish-mobile-github-release.ymlRegression test workflow triggered on PRs that change
_publish-mobile-github-release.yml. Creates a test draft release in this repo with a unique tag and test version in the title, calls the base workflow indry_runmode with a fake store version check command, then cleans up the draft regardless of outcome.The production
check_release_commanduses Fastlane to query the App Store or Play Store, which requires store credentials not available in this repo. The fake command simply echoes a version string that matches the draft release title, allowing the base workflow to continue without making any actual API calls to the stores.README.mdDocuments the base workflow and the regression testing approach.
Files Modified
_publish-mobile-github-release.ymlChanges required to support the test:
.ruby-versionfile in the iOS or Android repo. When the workflow is executed by the test workflow, there won't be a version file in this repo. Added a detection step that defaults to Ruby 3.2 if no .ruby-version file exists.credentials_filenameinput is empty.secrets: inherit. Secrets being passed into reusabale workflows need to be explicitly listed instead. When doing that in the calling workflow, the reusable workflow also needs the secrets explicitly listed.🚨 Breaking Changes
The changes to
_publish-mobile-github-release.ymllisted above shouldn't break the current production runs, but should be noted.