[PM-37888] refactor: Read masterKeyWrappedUserKey from masterPasswordUnlock#2780
Draft
matt-livefront wants to merge 8 commits into
Draft
Conversation
…eyConnectorUrl method
…UnlockMethod instead of persisting in state
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## matt/PM-37886-key-connector-encrypted-user-key #2780 +/- ##
=================================================================================
Coverage ? 87.90%
=================================================================================
Files ? 1716
Lines ? 167825
Branches ? 0
=================================================================================
Hits ? 147530
Misses ? 20295
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
934fd0a to
f9ca3ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-37888
📔 Objective
Updates instances of
AccountEncryptionKeys.encryptedUserKeyto instead useUserDecryptionOptions.masterPasswordUnlock?.masterKeyEncryptedUserKeysince these are all called for users with a master password. I've leftAccountEncryptionKeys.encryptedUserKeyfor now, to be cleaned up in a separate PR.unlockVaultFromLoginWithDevice,validatePassword, andKeyConnectorService.migrateUserto read the master-key-encrypted user key fromUserDecryptionOptions.masterPasswordUnlock?.masterKeyEncryptedUserKeyinstead ofAccountEncryptionKeys.encryptedUserKeysetAccountMasterPasswordUnlockcall in the V1 JIT and TDE paths ofsetMasterPassword(these paths previously never populatedmasterPasswordUnlock, so subsequent reads would return nil)setAccountMasterPasswordUnlockcall inupdateMasterPasswordso the canonical source stays current after a password changeencryptedUserKey: nilon all master-password-relatedsetAccountEncryptionKeyscalls — the value now lives exclusively inmasterPasswordUnlock