Skip to content

[pm-39192] feat: Updates premium upsell button copy to "Learn more"#2801

Open
morganzellers-bw wants to merge 3 commits into
mainfrom
pm-39192-update-premium-upsell-copy
Open

[pm-39192] feat: Updates premium upsell button copy to "Learn more"#2801
morganzellers-bw wants to merge 3 commits into
mainfrom
pm-39192-update-premium-upsell-copy

Conversation

@morganzellers-bw

@morganzellers-bw morganzellers-bw commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39192

📔 Objective

Update the text of the button on the "Unlock advanced security features" upsell banner to "Learn more".

📸 Screenshots

Screenshots Here

Before

premium_before

After

premium_after

@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:feature labels Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.83%. Comparing base (0185de5) to head (5124714).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hared/UI/Vault/Vault/VaultList/VaultListView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
- Coverage   80.83%   80.83%   -0.01%     
==========================================
  Files        1018     1018              
  Lines       64903    64903              
==========================================
- Hits        52463    52462       -1     
- Misses      12440    12441       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morganzellers-bw morganzellers-bw marked this pull request as ready for review June 18, 2026 17:19
@morganzellers-bw morganzellers-bw requested review from a team and matt-livefront as code owners June 18, 2026 17:19
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-line UI copy change in VaultListView.swift that updates the premium upsell ActionCard button title from Localizations.upgradeToPremium to Localizations.learnMore. Verified the LearnMore localization key exists and is translated across all locale .strings files, and confirmed the .upgradeToPremium action handler is unchanged so button behavior is preserved. The Codecov 0% patch note covers the view-layer title literal, which is exercised by snapshot tests (currently disabled per repo policy) rather than unit tests.

Code Review Details

No findings. Clean copy-only change with correct localization wiring and no behavioral impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants