Skip to content

[PM-37318] chore: Standardize premium upgrade alert titles to "Premium subscription required" #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KatherineInCode merged 2 commits into from
Jun 23, 2026
Merged

[PM-37318] chore: Standardize premium upgrade alert titles to "Premium subscription required" #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db8eabe
[PM-37318] chore: Standardize premium upgrade alert titles to "Premiu…
KatherineInCode Jun 17, 2026
639c233
Merge branch 'main' into pm-37318/upgrade-to-premium
KatherineInCode Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions BitwardenResources/Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,10 +1026,8 @@
"ArchiveEmptyDescriptionLong" = "Fill your archive with items you don’t want to see in search results and autofill suggestions but might need someday.";
"ArchiveItem" = "Archive item";
"OnceArchivedThisItemWillBeExcludedDescriptionLong" = "Once archived, this item will be excluded from search results and autofill suggestions.";
"ArchiveUnavailable" = "Archive unavailable";
"ArchivingItemsIsAPremiumFeatureDescriptionLong" = "Archiving items is a Premium feature. Your current plan does not include access to this feature.";
"AddingAttachmentsIsAPremiumFeatureDescriptionLong" = "Adding attachments is a Premium feature. Your current plan does not include access to this feature.";
"AttachmentsUnavailable" = "Attachments unavailable";
"UpgradeToPremium" = "Upgrade to Premium";
"ThisItemIsArchived" = "This item is archived.";
"YourPremiumSubscriptionEnded" = "Your Premium subscription ended";
Expand Down
2 changes: 0 additions & 2 deletions BitwardenShared/Core/Platform/Services/KeyConnectorServiceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import XCTest
@testable import BitwardenShared
@testable import BitwardenSharedMocks

// swiftlint:disable file_length

@MainActor
class KeyConnectorServiceTests: BitwardenTestCase { // swiftlint:disable:this type_body_length
// MARK: Properties
Expand Down
4 changes: 2 additions & 2 deletions BitwardenShared/UI/Vault/Extensions/Alert+Vault.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ extension Alert {
await action()
}
let alert = Alert(
title: Localizations.archiveUnavailable,
title: Localizations.premiumSubscriptionRequired,
message: Localizations.archivingItemsIsAPremiumFeatureDescriptionLong,
alertActions: [
preferredAction,
Expand All @@ -43,7 +43,7 @@ extension Alert {
await action()
}
let alert = Alert(
title: Localizations.attachmentsUnavailable,
title: Localizations.premiumSubscriptionRequired,
message: Localizations.addingAttachmentsIsAPremiumFeatureDescriptionLong,
alertActions: [
preferredAction,
Expand Down
2 changes: 1 addition & 1 deletion BitwardenShared/UI/Vault/Extensions/AlertVaultTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class AlertVaultTests: BitwardenTestCase { // swiftlint:disable:this type_body_l
var called = false
let subject = Alert.archiveUnavailable { called = true }

XCTAssertEqual(subject.title, Localizations.archiveUnavailable)
XCTAssertEqual(subject.title, Localizations.premiumSubscriptionRequired)
XCTAssertEqual(subject.message, Localizations.archivingItemsIsAPremiumFeatureDescriptionLong)
XCTAssertEqual(subject.alertActions.count, 2)
XCTAssertEqual(subject.alertActions[0].title, Localizations.upgradeToPremium)
Expand Down
2 changes: 1 addition & 1 deletion BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,7 +2090,7 @@ class VaultListProcessorTests: BitwardenTestCase { // swiftlint:disable:this typ
subject.receive(.itemPressed(item: archiveItem))

let alert = try XCTUnwrap(coordinator.alertShown.last)
XCTAssertEqual(alert.title, Localizations.archiveUnavailable)
XCTAssertEqual(alert.title, Localizations.premiumSubscriptionRequired)
XCTAssertEqual(alert.message, Localizations.archivingItemsIsAPremiumFeatureDescriptionLong)

try await alert.tapAction(title: Localizations.upgradeToPremium)
Expand Down
2 changes: 1 addition & 1 deletion BitwardenShared/UI/Vault/VaultItem/VaultItemActionHelperTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ struct VaultItemActionHelperTests {
)

let alert = try #require(coordinator.alertShown.last)
#expect(alert.title == Localizations.archiveUnavailable)
#expect(alert.title == Localizations.premiumSubscriptionRequired)
#expect(alert.message == Localizations.archivingItemsIsAPremiumFeatureDescriptionLong)
#expect(vaultRepository.archiveCipher.isEmpty)
#expect(!completionCalled)
Expand Down
Loading