[PM-39279] chore: Remove unnecessary ErrorReportBuilderTests setup#2807
[PM-39279] chore: Remove unnecessary ErrorReportBuilderTests setup#2807matt-livefront wants to merge 1 commit into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the removal of UI appearance setup ( Code Review DetailsNo findings. The removed setup served no purpose for these text-based inline snapshot tests, and no test body or the subject under test relies on main-actor isolation or the UI appearance state. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2807 +/- ##
===========================================
- Coverage 80.82% 40.65% -40.18%
===========================================
Files 1018 356 -662
Lines 64941 16583 -48358
===========================================
- Hits 52490 6742 -45748
+ Misses 12451 9841 -2610 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
PM-39279
📔 Objective
Removes some unnecessary setup in
ErrorReportBuilderTests.Swift Testing makes it hard to see how long these tests take in the larger suite of tests, but sometimes I see these tests popping up with long test times (>1 second). I'm not sure how much of an effect this will have, but the tests seemed faster in the runs that I did without this setup. And there's no UI here, so there shouldn't be any downsides.