Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BRE-2094] Update CD workflow and add Publish workflow #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[BRE-2094] Update CD workflow and add Publish workflow #142
Changes from all commits
d8d1afe5530d960563666File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β QUESTION: Does the release process now include bumping
package.jsonbefore tagging?Context
package.jsonhas been pinned at1.0.0since the initial commit (git log -S '"version"' -- package.jsonshows no bumps), yet tags1.0.1and1.0.1-beta.1exist. The old flow passed the version downstream explicitly (--field version="${TAG_NAME}"), so the in-repo version never had to match.With this gate, the next release tagged anything other than
1.0.0fails here and no asset is attached, blocking publish. That is fine if a version-bump PR is now part of the release runbook β just confirming that step exists, since nothing in this repo automates it.Uh oh!
There was an error while loading. Please reload this page.