[BRE-2009] fix(marketplace): run setup wizard on demand#523
Open
fntyler wants to merge 1 commit into
Open
Conversation
[BRE-2009](https://bitwarden.atlassian.net/browse/BRE-2009) The edition-selection wizard auto-launched on every login via /etc/profile.d, blocking any login-shell session — including the Azure Marketplace certification harness — on its `read` prompt. Stop auto-launching it; advertise it through the MOTD and let the user run it on demand. Robust for every session type (PTY or non-PTY, login or command exec) and fixes the latent hang for non-interactive SSH (scp/automation) against customer VMs. * Delete the /etc/profile.d/bitwarden-first-login.sh auto-launch trigger and its references in the Azure/AWS/DO packer builds * MOTD now instructs the user to run `sudo bitwarden-setup` when no edition has been selected * Symlink setup-wizard.sh to /usr/local/bin/bitwarden-setup; drop the wizard's self-removal of the trigger * Update the 001_onboot comment to reference the on-demand wizard
|
fntyler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BRE-2009
📔 Objective
The edition-selection wizard auto-launched on every login via /etc/profile.d, blocking any login-shell session — including the Azure Marketplace certification harness — on its
readprompt. This change stops auto-launching it upon login but instead advertises it through the MOTD. The user will instead run setup on demand. Beneficial for every session type (PTY or non-PTY, login or command exec) and fixes the latent hang for non-interactive SSH (scp/automation) against VMs/hosts/instances.sudo bitwarden-setupwhen no edition has been selected📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes