Skip to content

chore(PULL_REQUEST_TEMPLATE): expandable sections#524

Open
fntyler wants to merge 1 commit into
mainfrom
th/chore-pr-template
Open

chore(PULL_REQUEST_TEMPLATE): expandable sections#524
fntyler wants to merge 1 commit into
mainfrom
th/chore-pr-template

Conversation

@fntyler

@fntyler fntyler commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

null

📔 Objective

The "Reminders before review" and "Reviewer guidelines" takes up a large portion of browser/client real estate when creating, reviewing, or viewing PRs. This puts details into expandable sections.

Example:

Details
  • Example 1 👋
  • Example 2 👍

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

The "Reminders before review" and "Reviewer guidelines" takes up a
large portion of browser/client realestate when creating, reviewing, or
viewing PRs. This puts details into expandable sections.
@fntyler fntyler requested a review from a team as a code owner June 11, 2026 21:56
@fntyler fntyler requested a review from keithhubner June 11, 2026 21:56
@fntyler fntyler enabled auto-merge (squash) June 11, 2026 21:57
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR wraps the "Reminders before review" and "Reviewer guidelines" sections of .github/PULL_REQUEST_TEMPLATE.md in collapsible <details> blocks to reduce visual clutter when creating or reviewing PRs. The markdown is well-formed — blank lines are correctly placed around the <details> and </details> tags so the bullet list content inside still renders as markdown on GitHub. No code paths, dependencies, or security-sensitive areas are affected.

@sonarqubecloud

Copy link
Copy Markdown

@mimartin12 mimartin12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly like this, because for someone who isn't a regular contributor, they don't have the information front and center. I understand that it does eat a bit into overall screen real estate, but the information is helpful to how the team reviews PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants