Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
7af0b81 to
c19faae
Compare
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
==========================================
- Coverage 58.53% 58.44% -0.09%
==========================================
Files 2069 2067 -2
Lines 91306 91016 -290
Branches 8128 8085 -43
==========================================
- Hits 53443 53197 -246
+ Misses 35954 35916 -38
+ Partials 1909 1903 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdenney
left a comment
There was a problem hiding this comment.
Logic looks good! Only thing I'd ask is if you could add some unit tests to cover the new changes? We've had issues in the past with changes to the licensing logic causing regressions so I like to make sure we cover that area pretty thoroughly. Thanks!
| { | ||
| ValidateIssuerSigningKey = true, | ||
| IssuerSigningKey = new X509SecurityKey(_certificate), | ||
| IssuerSigningKey = issuerKey, |
There was a problem hiding this comment.
| IssuerSigningKey = issuerKey, | |
| IssuerSigningKeys =_verificationCertificates.Select((c) => new X509SecurityKey(c)), |
This should also mean you don't need to do any merges since only one would be valid anyways. This just says both of those keys are valid.




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34880
https://bitwarden.atlassian.net/browse/PM-34881
https://bitwarden.atlassian.net/browse/PM-34886
📔 Objective
Various tweaks to smooth qa automation testing.
📸 Screenshots