Skip to content

[PM-32069] Add ExtendedProviderAbilityCacheService#7447

Open
JimmyVo16 wants to merge 4 commits intomainfrom
ac/pm-32069/add-extended-provider-cache
Open

[PM-32069] Add ExtendedProviderAbilityCacheService#7447
JimmyVo16 wants to merge 4 commits intomainfrom
ac/pm-32069/add-extended-provider-cache

Conversation

@JimmyVo16
Copy link
Copy Markdown
Contributor

@JimmyVo16 JimmyVo16 commented Apr 10, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32069
https://bitwarden.atlassian.net/browse/PM-32112

📔 Objective

  1. Add extended cache for the provider service (IProviderAbilityCacheService).
  2. Inject IProviderAbilityCacheService into FeatureRoutedCacheService behind a feature flag.
  3. Add unit tests.

📸 Screenshots

This code isn't wired up yet, so we can't manually test it, but I feel like the automated test coverage is sufficient.

@JimmyVo16 JimmyVo16 self-assigned this Apr 10, 2026
@JimmyVo16 JimmyVo16 added the ai-review Request a Claude code review label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Logo
Checkmarx One – Scan Summary & Details7914cba4-4066-4bdb-9fe6-88ec9835012e

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR introduces ExtendedProviderAbilityCacheService backed by FusionCache, defines the IProviderAbilityCacheService interface, and routes single-provider ability cache operations through the ProviderAbilityExtendedCache feature flag in FeatureRoutedCacheService. DI registrations are correctly placed in both ServiceCollectionExtensions (for services using AddDefaultServices) and Events/Startup.cs (which has standalone registration). Tests thoroughly cover all feature-flag-on and feature-flag-off code paths for get, upsert, and delete operations.

No issues found.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.68%. Comparing base (f2141b9) to head (43bfc80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7447      +/-   ##
==========================================
+ Coverage   58.66%   58.68%   +0.01%     
==========================================
  Files        2066     2067       +1     
  Lines       91089    91124      +35     
  Branches     8106     8109       +3     
==========================================
+ Hits        53440    53475      +35     
  Misses      35740    35740              
  Partials     1909     1909              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@JimmyVo16 JimmyVo16 marked this pull request as ready for review April 14, 2026 14:39
@JimmyVo16 JimmyVo16 requested review from a team as code owners April 14, 2026 14:39
@JimmyVo16 JimmyVo16 requested a review from BTreston April 14, 2026 14:39
@JimmyVo16
Copy link
Copy Markdown
Contributor Author

I looked at the failed Build Docker images (SeederApi, ./util, linux/amd64, linux/arm64, true) job. It looks like a permission issue when logging into Azure. I don't think this is related to my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant