Skip to content

chore: remove checkmarx and sonar from the project - #262

Merged
sognefej merged 2 commits into
mainfrom
remove-checkmarx
Aug 4, 2026
Merged

chore: remove checkmarx and sonar from the project#262
sognefej merged 2 commits into
mainfrom
remove-checkmarx

Conversation

@sognefej

Copy link
Copy Markdown
Contributor

📔 Objective

Going through and removing all the Checkmarx and Sonar related code from the project.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sognefej
sognefej requested review from a team as code owners July 31, 2026 18:51
@sognefej
sognefej requested a review from pixman20 July 31, 2026 18:51
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR removes Checkmarx and Sonar from the project: the .github/workflows/examples/scan.yaml template is deleted, and the checkmarx/ast-github-action and sonarsource/sonarqube-scan-action entries are dropped from default_actions.json. The example workflow deletion is self-contained — nothing in the repo, tests, or CI (ci.yml lints examples/example.yaml) references it. The default_actions.json change, however, is the org-wide pre-approved action allowlist distributed via PyPI and enforced at error level by RuleStepUsesApproved, so it has blast radius beyond this repository.

Code Review Details
  • ⚠️ : Removing approved-action entries revokes org-wide approval; consumers still using these actions will fail lint at error level
    • src/bitwarden_workflow_linter/default_actions.json:207
  • 🎨 : The added trailing newline diverges from save_actions() output (src/bitwarden_workflow_linter/actions.py:185), so the weekly automated update PR will silently revert it

PR Metadata Assessment

  • QUESTION: No version:* label is applied; allowlist removals are breaking for consumers, so version:major looks warranted.

Comment thread src/bitwarden_workflow_linter/default_actions.json
@sognefej

Copy link
Copy Markdown
Contributor Author

Comment thread src/bitwarden_workflow_linter/default_actions.json
@fntyler

fntyler commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Has this been formally announced? I expect a lot of cleanup is to come

@sognefej

Copy link
Copy Markdown
Contributor Author

Has this been formally announced? I expect a lot of cleanup is to come

Yeah this was announced in Slack a few weeks ago by @mandreko-bitwarden, @fntyler

We are in the middle of transitioning everything to Aikido.

The @bitwarden/team-appsec has been submitting PRs to remove Checkmarx and Sonar from the Bitwarden codebase.

@sognefej
sognefej merged commit 93c4951 into main Aug 4, 2026
44 of 45 checks passed
@sognefej
sognefej deleted the remove-checkmarx branch August 4, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants