Fix semantic foreground mapping to ANSI color7 across mappers#80
Merged
bjarneo merged 6 commits intobjarneo:mainfrom Feb 22, 2026
Merged
Fix semantic foreground mapping to ANSI color7 across mappers#80bjarneo merged 6 commits intobjarneo:mainfrom
bjarneo merged 6 commits intobjarneo:mainfrom
Conversation
3f889f4 to
964f074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes Aether’s semantic role mapping so
foregroundfollows ANSIcolor7(white/default foreground), notcolor15(bright white).It also aligns related defaults to
color7:cursorselection_backgroundANSI slot mappings remain unchanged (
color15is still bright white).Changes
src/cli/utils/color-mapper.jssrc/state/ThemeState.jssrc/components/ColorSynthesizer.jssrc/constants/colors.jsdocs/base16.mddocs/color-extraction.mdWhy
Aether was assigning semantic
foregroundfrom slot 15, which conflictswith ANSI/Base16 semantics where default foreground text corresponds to
slot 7 and slot 15 is bright white.
Verification
foreground -> color7cursor -> color7selection_background -> color7src/still assigns these frompalette[15].Notes
selection_foregroundremains unchanged.npm run format:checkcould not run in this environment becauseprettieris not installed (prettier: command not found).