feat: Add adoption-step bridge and agent-ops guardrail signals to /assess - #285
Conversation
…sess Map the maturity band onto Boris Cherny's Steps of AI Adoption ladder in the report (a bound on safe agent autonomy, not a claim about team behaviour), and add a deterministic lib/agent_ops.py scan of encoded agent-operations guardrails (.claude settings permission allowlists, hooks, sandbox config, routine definitions) as Layer 8 workflow-maturity evidence. Tracked-only credit mirrors the Layer 0 rule; .claude/agents/ and .claude/skills/ stay Layer 0 evidence to avoid double-counting.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe assessment gains a tracked agent-operations scanner for Claude settings, hooks, workflows, and routines. Its evidence is added to run context and Layer 8 scoring, with corresponding tests, documentation, maturity guidance, and a plugin version bump. ChangesAgent operations assessment
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Assessment
participant AgentOpsScanner
participant RunContext
participant Layer8Scorer
Assessment->>AgentOpsScanner: scan repository guardrails
AgentOpsScanner-->>RunContext: add agent_ops evidence
Layer8Scorer->>RunContext: read agent_ops summary
Layer8Scorer-->>Assessment: calculate workflow maturity
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).claude-plugin/plugin.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Claude Code ReviewCommit: Summary Clean, well-scoped MINOR feature. Two additions land against the repo own standard:
Contract checks all clean: version bumped 1.55.31 to 1.56.0 (MINOR, correct tier for a new feature); no dead links, em dashes, placeholder tokens, or secrets introduced. The adoption-ladder bridge is consistently framed as a bound on safe autonomy rather than a claim about team behaviour, and the Cherny-to-layer mapping is advisory prose rendered by the LLM, not scoring logic - appropriate. Findings
Bot Review Notes No unresolved CodeRabbit threads at review time (its check is still in progress). Verdict: APPROVE. |
Summary
Incorporates the two repo-observable takeaways from Boris Cherny's Steps of AI Adoption (July 2026) into
/assess:lib/agent_ops.pyscan surfaces encoded operational guardrails -.claude/settings.json/.claude/settings.local.jsonpermission allow/deny/ask counts, hook events, sandbox config,.claude/hooks/scripts, and routine definitions under.claude/workflows//.claude/routines/- as Layer 8 workflow-maturity evidence.Cherny's per-step guardrails map directly onto existing layers (self-verification loops = L5/L6, automated review = L7, agent instructions = L0, routines/permissions = L8), which is what makes the bridge sound. The org-side content of the ladder (procurement, spend caps, agent-count telemetry) is deliberately out of scope - not repo-observable.
Changes Made
skills/assess/scripts/lib/agent_ops.py(new): pure-stdlib scan; summary booleans credit git-tracked evidence only, mirroring the Layer 0 rule. Deliberately excludes.claude/agents/and.claude/skills/(Layer 0 evidence) to prevent double-counting.skills/assess/scripts/assess_core.py: wiresagent_opsintorun-context.jsonvia_safe.agents/assess-layer-scorer.md: Layer 8 readsagent_ops; each true summary boolean strengthens the workflow-maturity dimension, absence never lowers a verdict, and agent-ops evidence is never sufficient alone.skills/assess-findings/SKILL.md: the bridge table in the scorecard fold, with the fraction-based band rule reused for non-software archetypes.README.md: single attribution to Cherny's post (primary source, his Threads announcement linking the artifact), following the existing Karpathy single-attribution convention.skills/assess/scripts/lib/README.md:agent_ops.pymodule entry..claude-plugin/plugin.json: 1.55.31 → 1.56.0 (MINOR - new feature).Testing
skills/assesspytest: 1031 passed (7 new intests/test_agent_ops.py: tracked/untracked credit, malformed JSON degrade, non-git dir, hooks dir, routine dirs, empty repo), 2 skipped.scripts/pytest: 152 passed. Plugin contract pytest: 539 passed.assess_core.pyproduces theagent_opsblock (this repo has no.claude/dir, so it reads all-false - the honest negative);.assess/self-run churn reverted, not committed.Risk Assessment
Low-to-medium. The scan is additive read-side context behind
_safe(a failure degrades toavailable: false, never blocks a run). The report/rubric changes alter LLM-rendered prose only; scoring semantics change in one place (Layer 8 may score higher on repos with committed agent-ops config - lift-only by design).Deployment Notes
Standard plugin release flow; version bump included. No migration or config changes for existing users.
Summary by CodeRabbit
New Features
Documentation
Improvements