uses ConcurrentHashMap to increase performance#1
Open
nahian1005002 wants to merge 1 commit intobjrara:masterfrom
Open
uses ConcurrentHashMap to increase performance#1nahian1005002 wants to merge 1 commit intobjrara:masterfrom
nahian1005002 wants to merge 1 commit intobjrara:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously It used java.util.HashMap to store mapped pages with its indexes. Since HashMap is not thread safe, it used a lock to protect the HashMap to make the implementation thread safe. The lock creates significant lock contention at times in multi-threaded runs.
Here solution is implemented using java.util.concurrent.ConcurrentHashMap which is a thread-safe scalable implementation of hash map. It eliminates the contention and improves performance.