Open
Conversation
* Add @RestController annotation so it is used * The tests expected the controller to work for /api/user/current but it was mapped for /api/sayHello. This updates the DummyController to handle every URL since there are no other controllers.
* Use a POST because GET /logout just presents a log out form * Since a POST is used we must include a valid CSRF token * Log out success performs a redirect
We don't expect a 403, we expect a redirect to the log in page
* Previously the tests were using WebEnvironment.RANDOM_PORT which means an actual server is started up. However, WebTestClient was still being invoked without an HTTP request which means there is no need to start the server. * Rather than manually creating the WebTestClient, use @AutoConfigureWebTestClient
It is better to split up all the tests into focussed tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.