Add a hash to force QSPI memory reset if persistent data structure changes#85
Merged
xconverge merged 2 commits intobkshepherd:mainfrom Mar 6, 2026
Merged
Conversation
added 2 commits
March 6, 2026 11:40
…anged. Avoids hard faults.
Collaborator
|
Thanks for this, I will peek when I get a chance, I think it makes sense. I think the number of people who run into issues related to this is greater than the number of people who save settings and would be bummed to "lose them all". Especially since this mostly impacts someone doing development of some sort. I wont need to tell people to just temporarily adjust |
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching back to main branch from my personnal dev branch, I hit hard faults caused by incompatible persisted settings data.
This PR adds a layout hash to persistent settings. At startup, if the stored hash does not match the current layout hash, the firmware calls RestoreDefaults() to reset stale data and avoid loading invalid settings.