Use enums for parameter indexing

[chattob]

This is a PR that touches a lot of files, but the diff is mechanical (not functional) and the change pattern is mostly the same across modules. It should make the code easier to follow and reduce the chance of parameter indexing mistakes when coding.

What do you think?

Full disclosure: this was AI assisted but carefully reviewed by myself.

Summary

This PR cleans up parameter handling across the effect modules by replacing positional parameter indexes with named enum values. The main goal is to make the effect modules easier to read and safer to maintain.

What changed

• Added named parameter enums to each effect module
• Replaced magic-number parameter access with enum-based IDs
• Modified metadata definitions using std::array and local lambda initialization

[xconverge]

Did the agent find any that were wrong that this fixes? I think it's a good change and I like it

[spamatica]

Just chiming in that I'm all for this!
I think I actually have a branch where I did the same for just some of the effects... but as I just don't seem to get to the finish line these days I'm happy that others do! :)

[chattob]

Did the agent find any that were wrong that this fixes? I think it's a good change and I like it

No, there was nothing to fix. It's really just about readability.