Add check for encoder support.#88
Merged
xconverge merged 1 commit intobkshepherd:mainfrom Mar 18, 2026
Merged
Conversation
Collaborator
|
I only recently made a funbox and added the support to this repo. Whatever I was testing didn't involve the alternate foot switch so I didn't notice This makes sense though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GuitarML @xconverge don't you guys have issues with the Funbox?
I have a similar pedal variation (no encoder, no display). When I press the alternate footswith I often get the active effect changing to the next one on the list. This happens because of this code section:
// If alt footswitch held AND encoder turned, iterate to next/previous effect, also throttle the changes const int encoderIncrement = hardware.encoders[0].Increment();Because the
encodersvector is empty I get random non-zero values forIncrement().This PR defines explicitely if the pedal variation has an encoder or not.