Skip to content

Add check for encoder support.#88

Merged
xconverge merged 1 commit intobkshepherd:mainfrom
chattob:fix/explicit-encoder-support
Mar 18, 2026
Merged

Add check for encoder support.#88
xconverge merged 1 commit intobkshepherd:mainfrom
chattob:fix/explicit-encoder-support

Conversation

@chattob
Copy link
Copy Markdown
Contributor

@chattob chattob commented Mar 18, 2026

@GuitarML @xconverge don't you guys have issues with the Funbox?

I have a similar pedal variation (no encoder, no display). When I press the alternate footswith I often get the active effect changing to the next one on the list. This happens because of this code section:
// If alt footswitch held AND encoder turned, iterate to next/previous effect, also throttle the changes const int encoderIncrement = hardware.encoders[0].Increment();

Because the encodersvector is empty I get random non-zero values for Increment().
This PR defines explicitely if the pedal variation has an encoder or not.

@xconverge
Copy link
Copy Markdown
Collaborator

I only recently made a funbox and added the support to this repo. Whatever I was testing didn't involve the alternate foot switch so I didn't notice

This makes sense though!

@xconverge xconverge merged commit 5f73d54 into bkshepherd:main Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants