🎨 Palette: Improve accessibility of Copy button - #175
Conversation
Added aria-label and title to the icon-only CopyButton to provide an accessible name for screen readers and a native tooltip on hover. Additionally, added aria-hidden="true" to the internal Lucide icons to prevent redundant screen reader announcements. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
💡 What: Added
aria-label,title, andaria-hidden="true"attributes to the icon-onlyCopyButtoncomponent.🎯 Why: To provide an accessible name for screen readers, display a native tooltip on hover, and prevent screen readers from announcing decorative SVG icons, improving the overall accessibility and user experience of copying prompts.
📸 Before/After: No visual changes for non-assistive tech users, except for a native browser tooltip appearing on hover.
♿ Accessibility: Fixes a warning about missing accessible names on icon-only buttons and prevents redundant announcements of decorative icons.
PR created automatically by Jules for task 6229443975324260280 started by @billlzzz10
Summary by cubic
Improved accessibility of the icon-only Copy button by adding
aria-labelandtitlefor a readable name and tooltip, and marking the SVG icons asaria-hiddenso screen readers ignore them. The label switches between “Copy” and “Copied” based on state; visuals are unchanged.Written for commit 5d6efaf. Summary will update on new commits.