fix: use StateRoot for backup export and make dev.sh work on macOS#41
Open
zzabolazza wants to merge 1 commit into
Open
fix: use StateRoot for backup export and make dev.sh work on macOS#41zzabolazza wants to merge 1 commit into
zzabolazza wants to merge 1 commit into
Conversation
Backup export incorrectly scanned the install root on detached macOS apps; reuse BackupGetScopeDefinition. Also allow lsof when ss is unavailable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackupGetScopeDefinition, which resolves againstapppath.StateRootinstead of the install root. Fixes macOS.appexport failures that looked forContents/MacOS/datawhile writable state lives under Application Support.dev.shfalls back tolsofwhenssis unavailable so the macOS local launcher can start.Test plan
.app(detached), run 导出配置 and confirm it succeeds~/Library/Application Support/ant-browserrather than.app/Contents/MacOSbash ./dev.shand confirm it no longer fails withMissing required command: ssdev.shstill work as beforeMade with Cursor