fix: export RESOURCES_FOLDER from Paths module#332
Open
machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix: export RESOURCES_FOLDER from Paths module#332machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
…──────────────────────�[0m �[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;255;255;255mfix: export RESOURCES_FOLDER constant from Paths module�[0m �[38;5;238m 2�[0m �[38;5;238m│�[0m �[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;255;255;255mRESOURCES_FOLDER is defined in Paths.ts but not exported, making it�[0m �[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;255;255;255minaccessible via Electrobun.PATHS.RESOURCES_FOLDER despite being�[0m �[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;255;255;255mdocumented. Adding the export keyword so the existing import * in�[0m �[38;5;238m 6�[0m �[38;5;238m│�[0m �[38;2;255;255;255mindex.ts picks it up automatically.�[0m �[38;5;238m 7�[0m �[38;5;238m│�[0m �[38;5;238m 8�[0m �[38;5;238m│�[0m �[38;2;255;255;255mFixes blackboardsh#321�[0m �[38;5;238m─────┴──────────────────────────────────────────────────────────────────────────�[0m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
�[38;5;238m─────┬──────────────────────────────────────────────────────────────────────────�[0m
�[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;255;255;255m## Summary�[0m
�[38;5;238m 2�[0m �[38;5;238m│�[0m
�[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- Adds
exporttoRESOURCES_FOLDERinpackage/src/bun/core/Paths.tsso it's accessible viaElectrobun.PATHS.RESOURCES_FOLDER�[0m�[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- The constant was defined but not exported, making it
undefinedwhen accessed through the existingimport *re-export inindex.ts�[0m�[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- One-word change:
const→export const�[0m�[38;5;238m 6�[0m �[38;5;238m│�[0m
�[38;5;238m 7�[0m �[38;5;238m│�[0m �[38;2;255;255;255mFixes #321�[0m
�[38;5;238m─────┴──────────────────────────────────────────────────────────────────────────�[0m