fix: rename getLocallocalInfo to getLocalInfo (typo)#333
Open
machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix: rename getLocallocalInfo to getLocalInfo (typo)#333machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
machiabeli wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
…──────────────────────�[0m �[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;255;255;255mfix: rename getLocallocalInfo to getLocalInfo (typo)�[0m �[38;5;238m 2�[0m �[38;5;238m│�[0m �[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;255;255;255mThe Updater method was named getLocallocalInfo (double "local") but�[0m �[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;255;255;255mdocumented as getLocalInfo. Renames all 10 call sites across�[0m �[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;255;255;255mUpdater.ts and the kitchen example to match the documented API.�[0m �[38;5;238m 6�[0m �[38;5;238m│�[0m �[38;5;238m 7�[0m �[38;5;238m│�[0m �[38;2;255;255;255mFixes blackboardsh#254�[0m �[38;5;238m─────┴──────────────────────────────────────────────────────────────────────────�[0m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
�[38;5;238m─────┬──────────────────────────────────────────────────────────────────────────�[0m
�[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;255;255;255m## Summary�[0m
�[38;5;238m 2�[0m �[38;5;238m│�[0m
�[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- Renames
getLocallocalInfo(double "local" typo) togetLocalInfoto match the documented API name�[0m�[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- Updates all 10 call sites: 9 in
package/src/bun/core/Updater.ts+ 1 inkitchen/src/bun/index.ts�[0m�[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;255;255;255m- This is a breaking change for anyone using the typo'd name directly, but aligns with what the docs already say�[0m
�[38;5;238m 6�[0m �[38;5;238m│�[0m
�[38;5;238m 7�[0m �[38;5;238m│�[0m �[38;2;255;255;255mFixes #254�[0m
�[38;5;238m─────┴──────────────────────────────────────────────────────────────────────────�[0m