feat: native .icon format support for macOS Liquid Glass icons#351
Open
tsconfigdotjson wants to merge 1 commit intoblackboardsh:mainfrom
Open
feat: native .icon format support for macOS Liquid Glass icons#351tsconfigdotjson wants to merge 1 commit intoblackboardsh:mainfrom
tsconfigdotjson wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
When mac.icons points to a .icon file (from Icon Composer), the build pipeline now compiles it via actool, producing Assets.car for Liquid Glass on macOS 26+ and an .icns fallback for older versions. The existing .iconset → iconutil path is unchanged. Also adds exit code checking for both iconutil and actool to fail fast on broken icon builds instead of silently producing apps without icons. Closes blackboardsh#121 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@YoavCodes liquid glass icons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mac.iconspoints to a.iconfile (from Icon Composer), the build pipeline compiles it viaxcrun actool, producingAssets.car(Liquid Glass on macOS 26+) and a.icnsfallback for older macOS versionsmac.iconspoints to an.iconsetfolder, the existingiconutilpath is unchanged — no breaking changesCFBundleIconNameto Info.plist when using.iconformat (required forAssets.carlookup)actoolandiconutil(previously failures were silently swallowed)actoolavailability with a clear error message about requiring XcodeUsage
Validation
Validated in a clean room build (
/tmp/electrobun-cleanroom/):.iconfile into kitchen, seticons: "icon.icon"in configbun dev:canary(codesign/notarize disabled)Assets.carandAppIcon.icnsboth land inContents/Resources/Info.plistcontains bothCFBundleIconFile(AppIcon) andCFBundleIconName(icon)actool compilation output:
Closes #121
🤖 Generated with Claude Code